RFR: 8282477: [x86, aarch64] vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler [v5]

Dean Long dlong at openjdk.java.net
Tue May 3 22:39:42 UTC 2022


On Tue, 3 May 2022 07:36:55 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Fix the assertion by replacing it by assertion that does not fail.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove two superfluous assertions

OK, this looks good.  I had to refresh my memory on why I changed this code in 8161598.  In retrospect, I think having anchor frames always walkable by always storing a valid last_Java_pc would greatly simplify things, and I doubt any performance difference would be measurable.

-------------

Marked as reviewed by dlong (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8209


More information about the hotspot-dev mailing list