RFR: JDK-8283807: Handle CompileThreshold the same as other thresholds when scaled with -XX:CompileThresholdScaling [v3]

Tobias Holenstein duke at openjdk.java.net
Wed May 4 09:26:05 UTC 2022


On Mon, 2 May 2022 20:37:34 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Could you add a test case with several large values for -XX:CompileThresholdScaling and check that the warning message is printed?

I added a test now

> test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java line 264:
> 
>> 262:          * it is expected to print "outside the allowed range" warnings for
>> 263:          * the scaled flags
>> 264:          */
> 
> This comment is not very clear. Do you mean
> 
> 
> Max range tests expect a warning message of "outside the allowed range"
> but CompileThresholdScaling prints a different warning message when it's
> set too high.

I changed to comment. I hope it is clearer now

-------------

PR: https://git.openjdk.java.net/jdk/pull/8501


More information about the hotspot-dev mailing list