RFR: 8283849: AsyncGetCallTrace may crash JVM on guarantee [v2]

Jaroslav Bachorik jbachorik at openjdk.java.net
Thu May 5 12:24:16 UTC 2022


On Thu, 5 May 2022 12:00:49 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make sure the code blob result check is correct
>
> src/hotspot/share/runtime/thread.hpp line 649:
> 
>> 647:  // support ASGCT
>> 648:  private:
>> 649:   bool _in_asgct;
> 
> The position of this field may be significant. See if there are gaps in the Thread structure which this bool might be able to fill.

Just to clarify - you mean finding a gap due to padding and putting the field there?
The rest of the fields are usually clustered around the supported functionality so before I insert this flag somewhere in the middle of unrelated fields I want to be sure this is what we want.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8549


More information about the hotspot-dev mailing list