RFR: 8283849: AsyncGetCallTrace may crash JVM on guarantee [v3]

Jaroslav Bachorik jbachorik at openjdk.java.net
Thu May 5 12:43:18 UTC 2022


On Thu, 5 May 2022 12:13:49 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Naming and comments cleanup
>
> src/hotspot/share/runtime/thread.hpp line 649:
> 
>> 647:  // support AGCT
>> 648:  private:
>> 649:   bool _in_agct;
> 
> This should actually be in JavaThread as AGCT only operates on JavaThreads.

I will have to do check/cast in `CodeCache::find_blob()` as that may get called from any thread, not just Java threads.
I would assume that having this flag defined at Thread level is a lesser of the evils - or am I wrong here?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8549


More information about the hotspot-dev mailing list