RFR: 8286058: AArch64: clarify uses of MacroAssembler::trampoline_call [v2]

Andrew Haley aph at openjdk.java.net
Fri May 6 08:03:49 UTC 2022


On Thu, 5 May 2022 22:49:43 GMT, Evgeny Astigeevich <duke at openjdk.java.net> wrote:

>> `MacroAssembler::trampoline_call` is for generating calls of targets which are inside CodeCache and can have relocInfo types: `runtime_call_type`, `opt_virtual_call_type`, `static_call_type` or `virtual_call_type`.
>> This PR updates the description of the function and adds additional asserts.
>> Tested a fastdebug build:
>> - `gtest`: Passed
>> - `tier1`: Passed
>
> Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix assert message

src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 1103:

> 1101:   //
> 1102:   // Trampoline_call is most suitable for calls of Java methods. Java calls callees can be changed
> 1103:   // to the interpreter or different versions of a compiled method. Those callees can be

This is not true. Trampoline calls are needed for calls to the runtime too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8564


More information about the hotspot-dev mailing list