RFR: 8286058: AArch64: clarify uses of MacroAssembler::trampoline_call [v2]

Evgeny Astigeevich duke at openjdk.java.net
Fri May 6 09:45:49 UTC 2022


On Fri, 6 May 2022 08:04:25 GMT, Andrew Haley <aph at openjdk.org> wrote:

> "This prevents the call from optimization to a direct cal" is completely wrongl

If I am wrong, could you please point me at the place where 'adrp, add, bl' is optimized?

> As far as I can tell it is nonsense.

Could you please be more constructive?

> It introduces pointless confusing terminology such as "far-distant" and "near-distant".

Please, offer your variant. There is no standard terminology:
- GCC uses: long/short https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/ARM-Function-Attributes.html
- TI uses: relative/absolute/far away/near call https://downloads.ti.com/docs/esd/SPNU118/generate-far-call-trampolines-trampolines-option-stdz0755016.html
- ARM always calls tramopolines veneers: https://developer.arm.com/documentation/dui0803/d/pge1406301797482

We can use: short/long like GCC. What do you think?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8564


More information about the hotspot-dev mailing list