RFR: 8286476: x86_32: Fix crashes with non-preview mode after JDK-8284161 (Virtual Threads) [v3]
Coleen Phillimore
coleenp at openjdk.java.net
Tue May 10 14:16:45 UTC 2022
On Tue, 10 May 2022 14:06:32 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Virtual Threads are not fully implemented on x86_32. The feature is guarded with `--enable-preview`. But there is some VM code that is executed unconditionally anyway, crashing the VM on some tests. This improves the x86_32 code to the point that tests without `--enable-preview` run successfully. This adds the scaffolding for full implementation too.
>>
>> Additional testing:
>> - [x] Linux x86_32 fastdebug, `tier1` failures only with `--enable-preview`
>> - [x] Linux x86_32 fastdebug, `tier2` failures only with `--enable-preview`
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> x86-64 code still a bit wrong
Looks good. Thanks for fixing this.
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8630
More information about the hotspot-dev
mailing list