RFR: 8286376: Wrong condition for using non-immediate oops on AArch64

Stuart Monteith smonteith at openjdk.java.net
Mon May 16 12:55:50 UTC 2022


On Mon, 9 May 2022 11:12:32 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

> With the introduction of loom, nmethod entry barriers were added for all GCs. So far, the use of nmethod entry barriers has implied that nmethod oops are patched in the instruction stream. That is no longer the case. A condition was added to make sure we still get non-immediate oops on AArch64 for collectors that use nmethod entry barriers, and support immediate oops. However, the condition was messed up, so we instead end up doing the wrong thing. We should do the right thing.

LGTM. We should look at the effect of removing these immediates and just use the constant pool in all cases.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8593


More information about the hotspot-dev mailing list