Integrated: 8286808: Loom: Simplify generate_cont_thaw by passing thaw_kind directly

Aleksey Shipilev shade at openjdk.java.net
Tue May 17 10:53:55 UTC 2022


On Mon, 16 May 2022 11:11:45 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> I was staring at this code for x86_32 port, and it seems `exception` implies `return_barrier`. This mostly irks me because we are passing `2` to `Continuation::prepare_thaw` and implicitly coercing it to `bool` during the call. We can instead call with `1` when `return_barrier`.
> 
> Further cleanup makes the change more obvious; we can pass `thaw_kind` directly to `generate_cont_thaw`, and thus simplify the code. Unused x86_32 and PPC64 stubs are just deleted without refactoring the args; this is supposed to produce a cleaner merge problem for current porting work.
> 
> Additional testing:
>  - [x] `java/lang/Thread/virtual` on Linux x86_64 fastdebug
>  - [x] `java/lang/Thread/virtual` on Linux AArch64 fastdebug
>  - [x] Build Linux x86_32
>  - [x] Build Linux PPC64

This pull request has now been integrated.

Changeset: b434b1f2
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/b434b1f23373280bfa38ea1cf8c97e5ef2ce25ab
Stats:     45 lines in 5 files changed: 12 ins; 16 del; 17 mod

8286808: Loom: Simplify generate_cont_thaw by passing thaw_kind directly

Reviewed-by: rpressler, rehn

-------------

PR: https://git.openjdk.java.net/jdk/pull/8725


More information about the hotspot-dev mailing list