RFR: 8286897: Loom: Cleanup x86_64 StubGenerator

Tue May 17 17:21:12 UTC 2022

On Tue, 17 May 2022 17:04:37 GMT, Ron Pressler <rpressler at openjdk.org> wrote:

> The changes looks fine, but why do you want to remove assert_asm? It's useful even though it's new and not applied to old code. 

It is quite fiddly and clunky, TBH. My concern is accidentally putting the wrong inline assembly into macro and producing weird side-effects that behave differently when assertions are enabled. This is a risk every assertion carries, by the assembly carries much greater risk here. I don't even want to start thinking how would a badly matched macro play out. (Also, in x86_32 port, I discovered the definition is under wrong `LP64` block, which ends up with funky linking errors).

I can leave `assert_asm` in, but this cleanup had removed the only two uses.

> But if there's a good reason to do so, then it should also be removed from the aarch64 port.

That would be something to do when cleaning up AArch64 StubGenerator.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8755