RFR: 8286944: Loom: Common ContinuationEntry cookie handling

Rickard Bäckman rbackman at openjdk.java.net
Wed May 18 10:23:55 UTC 2022


On Wed, 18 May 2022 09:46:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Platform-specific code injects the cookie to the head of ContinuationEntry. The value for this cookie is hard-coded in platform-specific code, which is fragile. It would be better to common the cookie handling a bit to ease porting. In fact, I have spent an hour trying to debug a thing where I mistyped a cookie value in x86_32 code, hence my interest.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug, `java/lang/Thread/virtual`
>  - [x] Linux AArch64 fastdebug, `java/lang/Thread/virtual`

Looks good.

-------------

Marked as reviewed by rbackman (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8762


More information about the hotspot-dev mailing list