RFR: 8286944: Loom: Common ContinuationEntry cookie handling
Aleksey Shipilev
shade at openjdk.java.net
Wed May 18 15:22:50 UTC 2022
On Wed, 18 May 2022 15:18:52 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Platform-specific code injects the cookie to the head of ContinuationEntry. The value for this cookie is hard-coded in platform-specific code, which is fragile. It would be better to common the cookie handling a bit to ease porting. In fact, I have spent an hour trying to debug a thing where I mistyped a cookie value in x86_32 code, hence my interest.
>>
>> Additional testing:
>> - [x] Linux x86_64 fastdebug, `java/lang/Thread/virtual`
>> - [x] Linux AArch64 fastdebug, `java/lang/Thread/virtual`
>
> I retested both x86_64 and AArch64 with new testgroups, and the tests are passing.
> We were thinking of renaming the ContinuationEntry class because it's not an entry but more of an anchor. Your suggestions are welcome @shipilev since it appears that you're doing a lot of porting work. We'll wait until things settle down though (maybe in JDK 20).
I don't care about the naming at this point :) Maybe later, indeed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8762
More information about the hotspot-dev
mailing list