RFR: 8272791: java -XX:BlockZeroingLowLimit=1 crashes after 8270947 [v2]

Andrew Haley aph at openjdk.java.net
Fri May 20 06:28:45 UTC 2022


On Thu, 19 May 2022 16:51:14 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Better
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 4858:
> 
>> 4856: address MacroAssembler::zero_words(Register base, uint64_t cnt)
>> 4857: {
>> 4858:   guarantee(wordSize <= BlockZeroingLowLimit,
> 
> Surely, this `guarantee` would now never fire? Maybe we should demote it to `assert` to protect from accidental range error. There is no need to pay the price in release bits, I think.

True.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8756


More information about the hotspot-dev mailing list