RFR: 8276789: Support C++ lambda in ResourceHashtable::iterate [v4]

Ioi Lam iklam at openjdk.java.net
Tue May 24 16:25:04 UTC 2022


On Tue, 24 May 2022 12:29:32 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   some clean up suggested by @stefank
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 672:
> 
>> 670:     SystemDictionaryShared::check_for_exclusion(k, &info);
>> 671:   };
>> 672:   _dumptime_table->iterate_all(check_for_exclusion);
> 
> Can't this be changed to just:
> `_dumptime_table->iterate_all(SystemDictionaryShared::check_for_exclusion);`
> 
> or maybe even:
> `_dumptime_table->iterate_all(check_for_exclusion);`

The second parameter to `SystemDictionaryShared::check_for_exclusion()` is a `DumpTimeClassInfo*` because NULL is allowed. However, the iterator requires a `DumpTimeClassInfo&`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8761


More information about the hotspot-dev mailing list