Integrated: 8272791: java -XX:BlockZeroingLowLimit=1 crashes after 8270947

[Andrew Haley]

On Tue, 17 May 2022 18:08:58 GMT, Andrew Haley <aph at openjdk.org> wrote:

> This is an assertion failure caused by setting `BlockZeroingLowLimit` < `wordSize`.
> 
> I believe there was some confusion when writing this code about whether `BlockZeroingLowLimit` should be in words or bytes, and it makes no sense for it to be less than a single word. If anyone ever tried to use a parameter < 8, it triggers an assertion.
> 
> This patch does two things. Firstly, it corrects a `guarantee` which erroneously used `zero_words_block_size` rather than `wordSize`. The value of both of these is 8, so it doesn't change anything in the generated code. Secondly, it clips the `BlockZeroingLowLimit` so that it doesn't trigger the assertion.
> 
> Perhaps it would be better to change the lower limit to 8 instead of this silent correction. There is no backward compatibility issue here, because any attempt to set `BlockZeroingLowLimit` < 8 in the past would have exited the VM with an error, so I don't believe a CSR is warranted if we do change the allowable range.
> 
> So, which should it be? Change the lower limit of the range of the `BlockZeroingLowLimit` system flag, or allow 1 still to be used and silently fix it? Opinions welcome.

This pull request has now been integrated.

Changeset: e17118aa
Author:    Andrew Haley <aph at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/e17118aa8afb14dfca049f19fd98a1483b2b5c1b
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

8272791: java -XX:BlockZeroingLowLimit=1 crashes after 8270947

Reviewed-by: shade, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/8756