RFR: 8287071: Loom: Cleanup x86_64 gen_continuation_enter [v3]
Aleksey Shipilev
shade at openjdk.java.net
Mon May 30 12:31:25 UTC 2022
> During x86_32 porting, I ended up rewriting the copy of x86_64 gen_continuation_enter significantly to make it more streamlined. The original x86_64 gen_continuation_enter should enjoy the similar streamlining, since it would likely to be the template for many other architectures.
>
> There might be more things to do, I would not know until x86_32 fully works. I am pretty sure current thing is self-sufficient.
>
> Brief tour of changes:
> - Check the incoming registers explicitly
> - Pass explicit argument registers to `fill_continuation_entry`
> - Use the usual `NativeCall` alignment code to produce a patchable call
> - Check that static stub is emitted, fail hard otherwise
> - Handle register shuffling for `exception_handler_for_return_address` the similar way we do it in `StubGenerator`
>
> Additional testing:
> - [x] Linux x86_64 fastdebug, prospective `jdk_loom hotspot_loom`
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Harmonize exception handler invocation
- Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
- Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
- Revert test groups
- Fix
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8802/files
- new: https://git.openjdk.java.net/jdk/pull/8802/files/a46b7b3d..a485bafd
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8802&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8802&range=01-02
Stats: 2932 lines in 90 files changed: 1655 ins; 639 del; 638 mod
Patch: https://git.openjdk.java.net/jdk/pull/8802.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8802/head:pull/8802
PR: https://git.openjdk.java.net/jdk/pull/8802
More information about the hotspot-dev
mailing list