RFR: 8287233: Crash in Continuation.enterSpecial: stop: tried to execute native method as non-native [v2]

[Ron Pressler]

On Tue, 31 May 2022 01:21:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ron Pressler has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change memory barriers
>
> src/hotspot/share/oops/method.cpp line 1335:
> 
>> 1333:     // This must come last, as it is what's tested in LinkResolver::resolve_static_call
>> 1334:     mh->_from_interpreted_entry = mh->get_i2c_entry();
>> 1335:     OrderAccess::storestore();
> 
> Technically this needs a release-store to pair with the load-acquire.
> 
> But what subsequent store is this final store being ordered with? If there is none then it would suffice for this sequence to be just:
> 
>     mh->_i2i_entry = mh->get_i2c_entry();
>     // This must come last, as it is what's tested in LinkResolver::resolve_static_call
>     Atomic::release_store(&mh->_from_interpreted_entry , mh->get_i2c_entry());

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8926