RFR: 8286301: Port JEP 425 to RISC-V [v2]
Fei Yang
fyang at openjdk.org
Thu Nov 3 02:04:59 UTC 2022
On Wed, 2 Nov 2022 09:03:16 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:
>> Fei Yang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix
>
> src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp line 1236:
>
>> 1234: guarantee(false, "Unknown Continuation native intrinsic");
>> 1235: }
>> 1236:
>
> aarch64 has some assertions here, do we need this?
>
> #ifdef ASSERT
> if (method->is_continuation_enter_intrinsic()) {
> assert(interpreted_entry_offset != -1, "Must be set");
> assert(exception_offset != -1, "Must be set");
> } else {
> assert(interpreted_entry_offset == -1, "Must be unset");
> assert(exception_offset == -1, "Must be unset");
> }
> assert(frame_complete != -1, "Must be set");
> assert(stack_slots != -1, "Must be set");
> assert(vep_offset != -1, "Must be set");
> #endif
Good catch. I think I missed this issue: "8293654: Improve SharedRuntime handling of continuation helper out-arguments". I have just added handling for RISC-V. I think this is kind of refactoring work and won't affect basic functionality. Thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/10917
More information about the hotspot-dev
mailing list