RFR: 8295893: Improve printing of Constant Pool Cache Entries [v2]

Matias Saavedra Silva matsaave at openjdk.org
Thu Nov 3 22:22:30 UTC 2022


On Thu, 27 Oct 2022 05:55:50 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added null check and resource mark
>
> For testing the handling of uninitialized ConstantPoolEntry's, you can do something like this:
> 
> - set a breakpoint at InstanceKlass::initialize_impl in gdb
> - when the breakpoint is hit, check if constants()->cache() is NULL
> - if not NULL, do this: `call constants()->cache()->print_on(tty)`
> 
> This should catch the problem in your earlier commit where you didn't check for the NULL Method pointer.

Thank you for the corrections and feedback @iklam @coleenp @dholmes-ora!

-------------

PR: https://git.openjdk.org/jdk/pull/10860


More information about the hotspot-dev mailing list