RFR: 8296231: Fix MEMFLAGS for CHeapBitMaps

David Holmes dholmes at openjdk.org
Fri Nov 4 01:59:34 UTC 2022


On Wed, 2 Nov 2022 14:24:07 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> Some usages of CHeapBitMaps rely on the default value of the MEMFLAGS argument (mtInternal). This is undesirable, and should be fixed.
> 
> I'd prefer to remove the default value, but there is currently a PR touching the BitMap classes, so I'd like to limit this Bug to only fixing the incorrect usage of mtInternal.

Looks reasonable to me too. Thanks.

I also "vote" against the MemFlagsMark - it would be too easy to include unintended allocations (that currently rely on default) and too hard to recognise you are within the scope of such a mark.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10948


More information about the hotspot-dev mailing list