RFR: 8286301: Port JEP 425 to RISC-V [v5]

Fei Yang fyang at openjdk.org
Sat Nov 5 02:14:29 UTC 2022


On Fri, 4 Nov 2022 14:19:08 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Fei Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review
>
> src/hotspot/share/oops/stackChunkOop.inline.hpp line 139:
> 
>> 137: bool stackChunkOopDesc::is_usable_in_chunk(void* p) const {
>> 138: #if (defined(X86) || defined(AARCH64) || defined(RISCV64)) && !defined(ZERO)
>> 139:   HeapWord* start = (HeapWord*)start_address() + sp() - frame::metadata_words;
> 
> This looks platform independent now, doesn't it? I think the cpp conditional can be removed. You can leave it also to the PPC64 port as I'll touch that line again. As you like.

I think I will leave it to the PR for PPC64. Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/10917


More information about the hotspot-dev mailing list