RFR: 8296470: Refactor VMError::report STEP macro to improve readability

Mon Nov 7 13:33:36 UTC 2022

Refactor the STEP macro in VMError::report to improve readability.
Right now the macro contains multiple statements on one line and the non-conventional control flow is even harder to understand.

This enhancement aims to do two things:
 1. It splits the macro into multiple lines with indentations which makes the structure of the C++ code generated by the preprocessor clearer.
  2. Separates the internal step logic from the decision logic which decides if a step should be taken with a STEP_IF(step_name_str, condition) macro

Testing: tier 1 + GHA

-------------

Commit messages:
 - Fix STEP_IF condition crash and clear_step_start_time
 - VMError::report STEP_IF and cleanup

Changes: https://git.openjdk.org/jdk/pull/11018/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11018&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296470
  Stats: 729 lines in 2 files changed: 169 ins; 297 del; 263 mod
  Patch: https://git.openjdk.org/jdk/pull/11018.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11018/head:pull/11018

PR: https://git.openjdk.org/jdk/pull/11018