RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v6]

[Alan Bateman]

On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR contains the API and implementation changes for JEP-434 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment.
>> 
>> [1] - https://openjdk.org/jeps/434
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make memory session a pure lifetime abstraction

src/java.base/share/classes/java/lang/ModuleLayer.java line 331:

> 329:                  "enableNativeAccess");
> 330:              target.implAddEnableNativeAccess();
> 331:              return this;

ModuelLayer.enableNativeAccess looks fine, we iterated on that in panama-foreign/pull/729. I assume you'll add @since 20. Also you might want to check the alignment, it looks like the method is indented by 5 instead of the usual 4 spaces.

-------------

PR: https://git.openjdk.org/jdk/pull/10872