RFR: 8296492: Remove ObjectLocker in JVMTI get_subgroups call [v2]

Coleen Phillimore coleenp at openjdk.org
Tue Nov 8 12:30:38 UTC 2022


On Tue, 8 Nov 2022 04:35:48 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Handle non OOM exceptions and rename subgroupsAsArray.
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 810:
> 
>> 808:   if (HAS_PENDING_EXCEPTION) {
>> 809:     CLEAR_PENDING_EXCEPTION;
>> 810:     return JVMTI_ERROR_OUT_OF_MEMORY;
> 
> Do we need to handle unexpected exceptions better, rather than just claiming they are OOME?

I added a case for returning JVMTI_ERROR_INTERNAL also.  In the spec
https://docs.oracle.com/en/java/javase/11/docs/specs/jvmti.html#universal-error
The other universal errors are inapplicable (and already checked in the case of JVMTI_ERROR_INVALID_THREAD_GROUP and the invalid environment one (by the jvmti code wrapper).

-------------

PR: https://git.openjdk.org/jdk/pull/11033


More information about the hotspot-dev mailing list