RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v10]

Jorn Vernee jvernee at openjdk.org
Tue Nov 8 16:36:34 UTC 2022


On Tue, 8 Nov 2022 16:30:14 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR contains the API and implementation changes for JEP-434 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment.
>> 
>> [1] - https://openjdk.org/jeps/434
>
> Maurizio Cimadamore has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revamp javadoc of Arena/MemorySession
>    Rename MemorySession::isOwnedBy to MemorySession::isAccessibleBy
>    Add Arena::isOwnedBy
>  - Javadoc tweaks in MemorySession/Arena

src/java.base/share/classes/java/lang/foreign/Linker.java line 119:

> 117:  *     <li>The memory session of {@code A} is {@linkplain MemorySession#isAlive() alive}. Otherwise, the invocation throws
> 118:  *     {@link IllegalStateException};</li>
> 119:  *     <li>The invocation occurs in same thread as the one {@linkplain MemorySession#isAccessibleBy(Thread) owning} the memory session of {@code R},

Suggestion:

 *     <li>The invocation occurs in same thread as the one {@linkplain MemorySession#isAccessibleBy(Thread) owning} the memory session of {@code A},

-------------

PR: https://git.openjdk.org/jdk/pull/10872


More information about the hotspot-dev mailing list