RFR: 8296492: Remove ObjectLocker in JVMTI get_subgroups call [v5]
David Holmes
dholmes at openjdk.org
Tue Nov 8 23:38:17 UTC 2022
On Tue, 8 Nov 2022 14:55:17 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields. Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Forgot a null check.
src/hotspot/share/prims/jvmtiEnvBase.cpp line 540:
> 538:
> 539: jthread *
> 540: JvmtiEnvBase::new_jthreadArray(int length, Handle *handles) {
Shouldn't this method need to cast the return value to `jthread*`? And potentially shouldn't all the jobject's now be jthread's?
-------------
PR: https://git.openjdk.org/jdk/pull/11033
More information about the hotspot-dev
mailing list