RFR: 8296515: RISC-V: Small refactoring for MaxReductionV/MinReductionV/AddReductionV node implementation [v2]

[Yanhong Zhu]

On Wed, 9 Nov 2022 03:52:47 GMT, Yanhong Zhu <yzhu at openjdk.org> wrote:

>> Gui Cao has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Use the same predicate as reduce_addI
>>  - Remove the REDUCTION_OP enumeration type and use Opcode to represent the operation
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1717:
> 
>> 1715:       vredxor_vs(tmp, src2, tmp);
>> 1716:       break;
>> 1717:     case Op_MaxReductionV:
> 
> We implemented Byte/Short MaxReductionV like this patch before. But there are 2 test cases that failed:
> jdk/jdk/incubator/vector/ShortMaxVectorTests.java 
> jdk/jdk/incubator/vector/ByteMaxVectorTests.java
> The reason is that "make_reduction_input" will return INT_MAX for Byte & Short type.
> Did you meet this problem?

> 

I see that this has been fixed in the previous PR 8271515.
Approved.

-------------

PR: https://git.openjdk.org/jdk/pull/11036