RFR: 8296630: Fix SkipIfEqual on AArch64 and RISC-V

Yadong Wang yadongwang at openjdk.org
Thu Nov 10 03:24:16 UTC 2022


SkipIfEqual was supposed to load a flag value from some memory, compare it with a input boolean value, and jump to a specific label they a equals. The implementation on x86 and s390 platforms meets expectations, and ppc uses SkipIfEqualZero. However, on AArch64 and RISC-V platforms, the input argument "value" is not used, and jumping-if-equal-zero is generated only. That's not correct, but works well since only false passed on all call sites so far.

AArch64 tier1, riscv hotspot & jdk tier1 have been tested.
Additional cases with dtrace tested on AArch64:
test/hotspot/jtreg/serviceability/dtrace/DTraceOptionsTest.java
test/hotspot/jtreg/compiler/runtime/Test8168712.java

-------------

Commit messages:
 - 8296630: Fix SkipIfEqual on AArch64 and RISC-V

Changes: https://git.openjdk.org/jdk/pull/11076/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11076&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296630
  Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/11076.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11076/head:pull/11076

PR: https://git.openjdk.org/jdk/pull/11076


More information about the hotspot-dev mailing list