RFR: 8295214: Generational ZGC: Guard nmethods from cross modifying code

David Holmes dholmes at openjdk.org
Thu Nov 10 04:55:33 UTC 2022


On Tue, 8 Nov 2022 16:19:47 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

> Generational ZGC will need to patch nmethod instructions outside of safepoints, and guard entries into the nmethods with cross modifying code fences. This is mostly taken care of by nmethod entry barrier code. But there are a few entries that don't go through nmethod entry barriers that need fixing. In particular when entering an nmethod by returning through the stack watermark barrier. This patch ensures that whenever the stack watermark barrier exposes a new nmethod, we also ensure that a cross modify fence is executed, so that any concurrently updated instructions can be safely executed.

> Hope this explanation makes sense

Yes thanks. I'm willing to let this ride and see if there are any issues later.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11042


More information about the hotspot-dev mailing list