RFR: 8296301: Interpreter(RISC-V): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options [v2]

Yanhong Zhu yzhu at openjdk.org
Thu Nov 10 12:36:37 UTC 2022


On Thu, 10 Nov 2022 08:08:49 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   replace atomic_addalw with atomic_addw
>
> src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp line 1739:
> 
>> 1737: void TemplateInterpreterGenerator::count_bytecode() {
>> 1738:   __ mv(x7, (address) &BytecodeCounter::_counter_value);
>> 1739:   __ atomic_addalw(noreg, 1, x7);
> 
> I think a simpler __ atomic_addw will do here? I don't think there is any memory ordering issue here.

Thank you for your review. Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/11051


More information about the hotspot-dev mailing list