RFR: 8296470: Refactor VMError::report STEP macro to improve readability

[Axel Boldt-Christmas]

On Tue, 8 Nov 2022 12:54:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Ok, I was afraid to look at this. I do like STEP_IF. Maybe the longer expressions could be functions ?

Are you think of the conditions in the STEP_IF macro? I think at least some of the longer expressions can be put on multiple lines.  I guess it is already done for `should_report_bug`. I think verbose should always be seen in the macro, but a `should_perform_step` might be better, but I feel it might just be a noisy indirection when reading (as all the conditions are fairly simple).  I should however fix the implicit bool conversions, they are both agains our style guide, and ugly. 

For the step logic I think there are a few places that things can be refactored without losing the ability of easily comparing the VMError::report code to the hs_err file output.

-------------

PR: https://git.openjdk.org/jdk/pull/11018