RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v9]
Claes Redestad
redestad at openjdk.org
Thu Nov 10 14:54:48 UTC 2022
On Wed, 9 Nov 2022 02:35:24 GMT, David Schlosnagle <duke at openjdk.org> wrote:
>> Claes Redestad has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 55 commits:
>>
>> - Revert accidental ModuleHashes change
>> - Merge branch 'master' into 8282664-polyhash
>> - Merge pull request #2 from luhenry/dev/cl4es/8282664-polyhash
>>
>> Unroll + Reorder BBs
>> - fixup! Handle size=0 and size=1 in Java
>> - Handle size=0 and size=1 in Java
>> - reorder BB to do single scalar first to avoid slowdown of short arrays, longer arrays jumps will be amortized by speedups
>> - Unroll loop for cnt1 < 32
>> - Merge pull request #1 from luhenry/dev/cl4es/8282664-polyhash
>>
>> Switch to forward approach for vectorization
>> - Fix vector loop
>> - fix indexing
>> - ... and 45 more: https://git.openjdk.org/jdk/compare/dd5d4df5...853a7575
>
> src/hotspot/share/opto/matcher.cpp line 1707:
>
>> 1705: if (x >= _LAST_MACH_OPER) {
>> 1706: fprintf(stderr, "x = %d, _LAST_MACH_OPER = %d\n", x, _LAST_MACH_OPER);
>> 1707: fprintf(stderr, "dump n\n");
>
> Should this be removed before merging?
> Suggestion:
Yes, fixed these in the latest version.
-------------
PR: https://git.openjdk.org/jdk/pull/10847
More information about the hotspot-dev
mailing list