RFR: 8296630: Fix SkipIfEqual on AArch64 and RISC-V [v2]

Yadong Wang yadongwang at openjdk.org
Fri Nov 11 08:34:10 UTC 2022


> SkipIfEqual was supposed to load a flag value from some memory, compare it with a input boolean value, and jump to a specific label they a equals. The implementation on x86 and s390 platforms meets expectations, and ppc uses SkipIfEqualZero. However, on AArch64 and RISC-V platforms, the input argument "value" is not used, and jumping-if-equal-zero is generated only. That's not correct, but works well since only false passed on all call sites so far.
> 
> AArch64 tier1, riscv hotspot & jdk tier1 have been tested.
> Additional cases with dtrace tested on AArch64:
> test/hotspot/jtreg/serviceability/dtrace/DTraceOptionsTest.java
> test/hotspot/jtreg/compiler/runtime/Test8168712.java

Yadong Wang has updated the pull request incrementally with one additional commit since the last revision:

  reverse branch order

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11076/files
  - new: https://git.openjdk.org/jdk/pull/11076/files/f927182d..8efa3014

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11076&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11076&range=00-01

  Stats: 10 lines in 2 files changed: 4 ins; 4 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/11076.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11076/head:pull/11076

PR: https://git.openjdk.org/jdk/pull/11076


More information about the hotspot-dev mailing list