Integrated: 8296630: Fix SkipIfEqual on AArch64 and RISC-V

Yadong Wang yadongwang at openjdk.org
Sun Nov 13 03:11:28 UTC 2022


On Thu, 10 Nov 2022 03:17:37 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

> SkipIfEqual was supposed to load a flag value from some memory, compare it with a input boolean value, and jump to a specific label they a equals. The implementation on x86 and s390 platforms meets expectations, and ppc uses SkipIfEqualZero. However, on AArch64 and RISC-V platforms, the input argument "value" is not used, and jumping-if-equal-zero is generated only. That's not correct, but works well since only false passed on all call sites so far.
> 
> AArch64 tier1, riscv hotspot & jdk tier1 have been tested.
> Additional cases with dtrace tested on AArch64:
> test/hotspot/jtreg/serviceability/dtrace/DTraceOptionsTest.java
> test/hotspot/jtreg/compiler/runtime/Test8168712.java

This pull request has now been integrated.

Changeset: a2cdcdd6
Author:    Yadong Wang <yadongwang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a2cdcdd65dbbc6717c363fc4e22d9b16a4dea986
Stats:     10 lines in 2 files changed: 8 ins; 0 del; 2 mod

8296630: Fix SkipIfEqual on AArch64 and RISC-V

Reviewed-by: ngasson, fyang, luhenry, aph

-------------

PR: https://git.openjdk.org/jdk/pull/11076


More information about the hotspot-dev mailing list