RFR: 8295146: Clean up native code with newer C/C++ language features

Julian Waters jwaters at openjdk.org
Mon Nov 14 01:41:24 UTC 2022


On Sun, 13 Nov 2022 23:08:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ code across the JDK can be replaced and simplified with cleaner language features that were previously not available due to required compatibility with the now unsupported Visual C++ 2017 compiler. These cleanups were highlighted by the very briefly integrated 8296115
>> 
>> No changes to the behaviour of the JDK has resulted in any way from this commit
>
> src/hotspot/share/utilities/debug.hpp line 172:
> 
>> 170: void report_fatal(VMErrorType error_type, const char* file, int line, const char* detail_fmt, ...) ATTRIBUTE_PRINTF(4, 5);
>> 171: void report_vm_out_of_memory(const char* file, int line, size_t size, VMErrorType vm_err_type,
>> 172:                              const char* detail_fmt, ...) ATTRIBUTE_PRINTF(5, 6);
> 
> Why were the ATTRIBUTE_PRINTFs removed?

The ATTRIBUTE_PRINTF macros are still there, just moved in front of the methods

-------------

PR: https://git.openjdk.org/jdk/pull/11081


More information about the hotspot-dev mailing list