RFR: 8296916: RISC-V: Move some small macro-assembler functions to header file [v2]

Fei Yang fyang at openjdk.org
Mon Nov 14 02:58:22 UTC 2022


On Mon, 14 Nov 2022 02:34:27 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Fei Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review
>
> src/hotspot/cpu/riscv/assembler_riscv.hpp line 2757:
> 
>> 2755:   // Bit-manipulation extension pseudo instructions
>> 2756:   // zero extend word
>> 2757:   void zext_w(Register Rd, Register Rs) {
> 
> Seems we can move `zext_w` to MacroAssembler too.

Done. But the caller should be aware that this actually uses instructions from the Bit-manipulation extension. I think the code comment should make this explicit. Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/11130


More information about the hotspot-dev mailing list