RFR: JDK-8296437: NMT incurs costs if disabled [v2]

Thomas Stuefe stuefe at openjdk.org
Mon Nov 14 07:41:59 UTC 2022


On Mon, 14 Nov 2022 02:21:25 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - reduce unnecessary diffs
>>  - explicit constructor for fake callstacks; revert default ctor
>
> src/hotspot/share/utilities/nativeCallStack.hpp line 67:
> 
>> 65:   static constexpr uintptr_t _fake_address =
>> 66:              (LP64_ONLY(0x4E4D54535441434BULL) // "NMTSTACK"
>> 67:                NOT_LP64(0x4E4D5453));          // "NMTS"
> 
> Why are the outer parentheses needed?

You are right, I'll remove them.

-------------

PR: https://git.openjdk.org/jdk/pull/11040


More information about the hotspot-dev mailing list