RFR: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"
Thomas Schatzl
tschatzl at openjdk.org
Mon Nov 14 10:04:34 UTC 2022
On Thu, 20 Oct 2022 08:28:09 GMT, Fei Yang <fyang at openjdk.org> wrote:
> This is a trivial change renaming a formal parameter for ZBarrierSetAssembler::load_at.
>
> On AArch64 and RISC-V, the last formal parameter for ZBarrierSetAssembler::load_at
> is named "tmp_thread". But the callers will pass an ordinary temporary register for
> this parameter which has no relation with the thread register. We should rename this
> formal parameter from "tmp_thread" to "tmp2".
>
> Testing: fastdebug builds on linux-aarch64 & linux-riscv64.
Marked as reviewed by tschatzl (Reviewer).
I would have changed it only for the use in x86_32 files, in the actual parameters, but others are okay as is, so go ahead pushing it.
Sorry for holding up this review for so long.
-------------
PR: https://git.openjdk.org/jdk/pull/10783
More information about the hotspot-dev
mailing list