RFR: JDK-8296906: VMError::controlled_crash crashes with wrong code and address [v2]

[Matthias Baesken]

On Mon, 14 Nov 2022 07:10:39 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> We have VMError::controlled_crash() in debug builds, whose job is to trigger clearly defined faults to test VM error reporting. VMError::controlled_crash(14) (the numbers don't mean anything and probably should be replaced with clear enums) is to crash with a SIGSEGV + SEGV_MAPERR mapping error at a well-known crash address. But this does not work on Linux, where it generates a SIGSEGV with SI_KERNEL instead. We never noticed since it had not been used in tests so far.
>> 
>> The reason for SI_KERNEL was that the crash address we use (0xABC0000000000ABC) was outside the user-space address range on Linux. This patch redefines the crash address to a value that really generates a SIGSEGV + SEGV_MAPERR on all our platforms. That's one line; the rest is a new regression test that checks that signal info is printed correctly in hs-err files.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   feedback david

Looks good to me.
Probably you  should adjust the SAP copyright header line in [src/hotspot/share/utilities/vmError.hpp](https://github.com/openjdk/jdk/pull/11122/files#diff-d01eccc98068519f691bbabbba6c192eb576d7c60a4e06567db0768141787f35)  to 2022 .

-------------

Marked as reviewed by mbaesken (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11122