RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v22]

Per Minborg pminborg at openjdk.org
Tue Nov 15 15:28:52 UTC 2022


On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR contains the API and implementation changes for JEP-434 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment.
>> 
>> [1] - https://openjdk.org/jeps/434
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add `since` tag in Module/ModuleLayer preview methods

src/java.base/share/classes/java/lang/foreign/Arena.java line 136:

> 134: 
> 135:     /**
> 136:      * {@return {@code true} if the provided thread can close this arena}

I think this is equivalent and simpler:

{@return if the provided thread can close this arena}.

But I know there are many examples of {@code true} in the JDK.

src/java.base/share/classes/java/lang/foreign/GroupLayout.java line 46:

> 44: 
> 45:     /**
> 46:      * Returns the member layouts associated with this group.

We may use {@return the member layouts associated with this group}.

src/java.base/share/classes/java/lang/foreign/Linker.java line 264:

> 262: 
> 263:     /**
> 264:      * Returns a symbol lookup for symbols in a set of commonly used libraries.

Use {@return ...}

-------------

PR: https://git.openjdk.org/jdk/pull/10872


More information about the hotspot-dev mailing list