RFR: 8296477: Foreign linker implementation update following JEP 434 [v4]

[Jorn Vernee]

On Tue, 8 Nov 2022 20:05:09 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Tweak copyright headers
>>  - Use @requires to disable some tests on x86
>>  - Use AssertionError for internal exceptions
>
> src/hotspot/cpu/aarch64/downcallLinker_aarch64.cpp line 146:
> 
>> 144:   Register tmp2 = r10;
>> 145: 
>> 146:   VMStorage shuffle_reg = VMS_R19;
> 
> I'd prefer to see `as_VMStorage(Register)` used instead and all `VMS_...` constants go away.

Yes, seems to be possible now that `as_VMStorage` can be made `constexpr`. Will do

> src/hotspot/cpu/aarch64/vmstorage_aarch64.inline.hpp line 68:
> 
>> 66: }
>> 67: 
>> 68: inline VMStorage as_VMStorage(Register reg) {
> 
> Mark as `constexpr` maybe?

Tried this before when `Register` wasn't as `constexpr` friendly due to the reinterpret casts. Seems to work now though (thanks! :)) I'll change all these to `constexpr`.

-------------

PR: https://git.openjdk.org/jdk/pull/11019