RFR: 8296477: Foreign linker implementation update following JEP 434 [v4]

Jorn Vernee jvernee at openjdk.org
Tue Nov 15 18:19:09 UTC 2022


On Tue, 15 Nov 2022 18:09:21 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Err, looks like this works for MSVC, but with GCC I hit a snag eventually (it also require putting `constexpr` on a lot of the `Register`/`VMReg` API).
>> 
>> This error occurs:
>> 
>> 
>> * For target hotspot_variant-server_libjvm_objs_downcallLinker.o:
>> In file included from /mnt/h/openjdk/foreign-abi/src/hotspot/share/prims/vmstorage.inline.hpp:100,
>>                  from /mnt/h/openjdk/foreign-abi/src/hotspot/share/prims/foreignGlobals.hpp:29,
>>                  from /mnt/h/openjdk/foreign-abi/src/hotspot/share/prims/downcallLinker.hpp:27,
>>                  from /mnt/h/openjdk/foreign-abi/src/hotspot/share/prims/downcallLinker.cpp:25:
>
> I guess there's also the possibility that this might trip up compilers on other platforms, even if I can manage to fix it here.

Looks like it was the next line after the one in the diagnostic that was actually the problem. I seem to have something working now.

-------------

PR: https://git.openjdk.org/jdk/pull/11019


More information about the hotspot-dev mailing list