RFR: JDK-8296906: VMError::controlled_crash crashes with wrong code and address [v3]

Thomas Stuefe stuefe at openjdk.org
Wed Nov 16 08:50:11 UTC 2022


On Wed, 16 Nov 2022 08:13:38 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix copyright
>
> test/hotspot/jtreg/runtime/ErrorHandling/HsErrFileUtils.java line 35:
> 
>> 33:      * Given the output of a java VM that crashed, extract the name of the hs-err file from the output
>> 34:      */
>> 35:     static public String extractHsErrFileNameFromOutput(OutputAnalyzer output) {
> 
> nit: let's use blessed modifiers order
> Suggestion:
> 
>     public static String extractHsErrFileNameFromOutput(OutputAnalyzer output) {

I had to look this up :-)

Sure.

-------------

PR: https://git.openjdk.org/jdk/pull/11122


More information about the hotspot-dev mailing list