Integrated: 8296776: Stop using mtNone as marker for CHeap allocations in GrowableArray

Stefan Karlsson stefank at openjdk.org
Wed Nov 16 10:56:43 UTC 2022


On Thu, 10 Nov 2022 09:40:44 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> Today we use mtNone to denote that a GrowableArray should *NOT* be backed by a CHeap allocated array.
> 
> I've gotten feedback that it would probably be good to limit the usage of mtNone, and at some point maybe completely remove it.
> 
> This patch takes a small step to remove mtNone from the GrowableArray. What's left is only asserts to forbid that value. Those asserts will be trivial to remove when/if mtNone is removed.
> 
> Just like in the proposed patch to make MEMFLAGS non-optional in CHeapBitMap (see JDK-[JDK-8296774](https://bugs.openjdk.org/browse/JDK-8296774)), I have thrown around the parameter order for GrowableArray. When looking at the changes to the usages of CHeap-backed GrowableArrays it becomes apparent that all of these usages where forced to provide a value for the initial capacity. When MEMFLAGS move to the front, we can now skip having to figure an initial capacity.

This pull request has now been integrated.

Changeset: 5f51dff6
Author:    Stefan Karlsson <stefank at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5f51dff6971d0f7ec7fd8e829a856fc4a45a7f3c
Stats:     48 lines in 1 file changed: 30 ins; 5 del; 13 mod

8296776: Stop using mtNone as marker for CHeap allocations in GrowableArray

Reviewed-by: sspitsyn, xliu, stuefe

-------------

PR: https://git.openjdk.org/jdk/pull/11086


More information about the hotspot-dev mailing list