RFR: 8297020: Rename GrowableArray::on_stack [v2]

Stefan Karlsson stefank at openjdk.org
Wed Nov 16 11:02:41 UTC 2022


> GrowableArray::on_stack is confusing. It returns true if the backing elements are allocated in the stack's resource area. We typically call this resource allocations, not stack allocations. I propose that we rename it.

Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Rename GrowableArray::on_stack
 - Spelling
 - Review tstuefe
 - Move now unnecessary 'explicit' specifier
 - Try to fix 32-bit builds
 - Merge remote-tracking branch 'upstream/master' into 8296776_growablearray_mtnone_cleanout_review
 - Review dholmes
 - Mark constructors explicit
 - 8296776: Stop using mtNone as marker for CHeap allocations in GrowableArray

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11161/files
  - new: https://git.openjdk.org/jdk/pull/11161/files/c16e0336..c16e0336

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11161&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11161&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/11161.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11161/head:pull/11161

PR: https://git.openjdk.org/jdk/pull/11161


More information about the hotspot-dev mailing list