RFR: 8296785: Use realloc for CHeap-allocated BitMaps [v2]

Stefan Karlsson stefank at openjdk.org
Wed Nov 16 16:49:17 UTC 2022


On Wed, 16 Nov 2022 14:48:57 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - 8296785: Use realloc for CHeap-allocated BitMaps
>>  - Merge remote-tracking branch 'upstream/master' into 8296774_bitmap_stricter_construction
>>  - 8296774: Removed default MEMFLAGS value from CHeapBitMap
>
> src/hotspot/share/utilities/bitMap.cpp line 53:
> 
>> 51: 
>> 52:   return map;
>> 53: }
> 
> Could this live inside `GrowableBitmap<T>` as a private static function?

It could, though I see that function as an implementation detail of ArenaBitMap and ResourceBitMap, that I don't want to burden CHeapBitMap with. I also like if we can keep the definition of GrowableBitMap simple, so that it's easier to read and understand. So, I'd prefer to not have to do this. I hope that's OK.

-------------

PR: https://git.openjdk.org/jdk/pull/11102


More information about the hotspot-dev mailing list