Integrated: 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value

Doug Simon dnsimon at openjdk.org
Wed Nov 16 21:24:37 UTC 2022


On Mon, 14 Nov 2022 19:37:20 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> This PR fixes a bug related to `HotSpotResolvedJavaFieldImpl.index`. Its value is passed into the `HotSpotResolvedJavaFieldImpl` constructor as an `int`, and is returned by `getIndex()` as an `int` but it was stored as a `short`. This meant that unsigned 16-bit values were not handled correctly.
> 
> Also included are some related JVMCI cleanups:
> * added and fixed doc related to `ResolvedJavaField.getOffset()`
> * replaced assertions with always-enabled checks

This pull request has now been integrated.

Changeset: 95c390ec
Author:    Doug Simon <dnsimon at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/95c390ec75eec31cdf613c8bb236e43aa65a1bb5
Stats:     180 lines in 7 files changed: 137 ins; 5 del; 38 mod

8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value

Reviewed-by: thartmann, never

-------------

PR: https://git.openjdk.org/jdk/pull/11142


More information about the hotspot-dev mailing list