RFR: JDK-8296796: Provide clean, platform-agnostic interface to C-heap trimming [v2]
David Holmes
dholmes at openjdk.org
Thu Nov 17 02:19:19 UTC 2022
On Mon, 14 Nov 2022 07:32:25 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> This is a breakout from [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved for reviews. So I attempt to break up that fix into smaller units which are hopefully easier to review separately.
>>
>> We can trim the C-heap manually using jcmd since [JDK-8268893](https://bugs.openjdk.org/browse/JDK-8268893). This patch reshapes this code, cleaning it up in an OS-agnostic way. That will allow us to add implementions for other platforms (I have this on my list for AIX at least) and make review of 8293114 easier.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>
> Feedback David
I don't disagree that C-heap trimming is useful even if only Linux does it. My objection is to defining a platform-agnostic API when only Linux does it.
-------------
PR: https://git.openjdk.org/jdk/pull/11089
More information about the hotspot-dev
mailing list