RFR: 8296975: RISC-V: Enable UseRVA20U64 profile by default [v3]

Xiaolin Zheng xlinzheng at openjdk.org
Thu Nov 17 06:38:56 UTC 2022


On Wed, 16 Nov 2022 05:21:52 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

>> The main purpose is to turn the option `UseRVC` on by default before JDK20 RDP 1. As per discussions [1], we can enable `UseRVA20U64`[2] by default to fulfill this.
>> 
>> 
>>> build/linux-riscv64-server-fastdebug/images/jdk/bin/java -XX:+PrintFlagsFinal -version | grep -E "UseRVC|UseRVA20U64"
>>      bool UseRVA20U64                              = true                                 {ARCH product} {default}
>>      bool UseRVC                                   = true                                 {ARCH product} {default}
>> openjdk version "20-internal" 2023-03-21
>> OpenJDK Runtime Environment (fastdebug build 20-internal-adhoc..jdk)
>> OpenJDK 64-Bit Server VM (fastdebug build 20-internal-adhoc..jdk, mixed mode)
>> 
>> 
>> [1] https://mail.openjdk.org/pipermail/riscv-port-dev/2022-November/000668.html
>> [2] https://github.com/openjdk/jdk/blob/873eccde01895de06e2216f6838d52d07188addd/src/hotspot/cpu/riscv/vm_version_riscv.cpp#L39-L44
>> 
>> Thanks,
>> Xiaolin
>
> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor issue if users specify command line -XX:+UseRVA20U64 and RVC is not supported

Receiving no further comments, I think I am okay as well to remain the current PR.

@luhenry 's suggestion also provides good thoughts for me, to dispatch the handling logic to `UseRVA20U64` and `UseRVA22U64` themselves, when hardware does not support RVC. Thank you. And it appears to me that `UseRVA20U64` is your code, I guess you would like to see that it is a default true value.

I think we can move forward with this, and I need certainly to keep an eye on if there are issues after this PR.

Thank you all for the reviews and thoughts!

-------------

PR: https://git.openjdk.org/jdk/pull/11155


More information about the hotspot-dev mailing list