RFR: JDK-8296907: VMError: add optional callstacks, siginfo for secondary errors [v3]

[Thomas Stuefe]

On Wed, 16 Nov 2022 17:25:38 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'JDK-8296907-VMError-add-optional-callstacks-siginfo-for-secondary-errors' of github.com:tstuefe/jdk into JDK-8296907-VMError-add-optional-callstacks-siginfo-for-secondary-errors
>>  - Feedback David
>
> src/hotspot/share/utilities/vmError.cpp line 1635:
> 
>> 1633:         // Any information (signal, context, siginfo etc) printed here should use the function
>> 1634:         // arguments, not the information stored in *this, since those describe the primary crash.
>> 1635:         char tmp[256]; // cannot use global scratch buffer
> 
> Is there any problems with making this static? Given that we care about the stack depth when we have repeated crashes.

I think not. At this point we are single threaded. I'll convert to static.

-------------

PR: https://git.openjdk.org/jdk/pull/11118